Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unused codepath to deal with unauthorized tokens #25

Open
ptone opened this issue Mar 1, 2011 · 0 comments
Open

unused codepath to deal with unauthorized tokens #25

ptone opened this issue Mar 1, 2011 · 0 comments

Comments

@ptone
Copy link
Member

ptone commented Mar 1, 2011

Not sure where this came from, whether original OAuth access project or what.

in the callback view there are these lines:

TODO: Check to make sure the session cookie is setting correctly

unauth_token = request.session.get("unauth_token", None)

this session var is never set elsewhere

the function OAuthAccess.check_token has code to check an unauthorized token, this code never gets called.

Currently we generate a new token (with new expiration date) every login. Because we don't know the FB user until the initiate a login - I'm not sure how we could really make use of an unauthorized token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant