Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connections page #150

Closed
10 tasks done
brunomenezes opened this issue Apr 9, 2024 · 0 comments 路 Fixed by #157
Closed
10 tasks done

Add connections page #150

brunomenezes opened this issue Apr 9, 2024 · 0 comments 路 Fixed by #157
Assignees
Labels
apps: web Type: Enhancement Improve an existing feature / design

Comments

@brunomenezes
Copy link
Collaborator

brunomenezes commented Apr 9, 2024

馃搫 Context

Today, the connections list lives inside an <aside> visible when clicking the vertical dots icon in the header. The intention is to allow the connection to have its page.

鉁旓笍 Solution

Move the connection to its page and remove the <aside /> and all mechanisms necessary for it to work.

  • Remove the vertical dots (a.k.a vertical kebab icon) and also the whole aside area.
  • Create a collapsable Settings with a connection link to the new page (Settings Icon TbAdjustmentsHorizontal).
  • Settings is a virtual grouping, i.e. no /settings route (For now).
  • Implement a connections page (/connections).
  • List the connection cards.

馃搱 Subtasks

  • Remove <aside /> and the mechanism to make it work.
  • Add Settings group with connection as sub-item.
  • Add new connection page under /connections route.
  • Remove collapse and scroll area from ConnectionView component
  • Remove obsolete tests for ConnectionView component
  • Add tests for Settings group

馃幆 Definition of Done

  • The previous view is removed, including all triggers to it. i.e. <aside>
  • Can list all the created connections under /connections.
  • Can create a connection from /connections.
  • All tests are passing.
@brunomenezes brunomenezes added Type: Enhancement Improve an existing feature / design apps: web labels Apr 9, 2024
@nevendyulgerov nevendyulgerov self-assigned this Apr 9, 2024
@nevendyulgerov nevendyulgerov linked a pull request Apr 11, 2024 that will close this issue
brunomenezes added a commit that referenced this issue Apr 30, 2024
Co-authored-by: Neven Dyulgerov <neven.diulgerov@gmail.com>
Co-authored-by: Bruno Menezes <brunodmenezes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps: web Type: Enhancement Improve an existing feature / design
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants