feat: add complex vouchers #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidanoli
force-pushed
the
feature/complex-vouchers
branch
2 times, most recently
from
ab8aed6
to
34b2333
Compare
guidanoli
force-pushed
the
feature/complex-vouchers
branch
from
34b2333
to
9799cc3
Compare
guidanoli
force-pushed
the
feature/complex-vouchers
branch
from
9799cc3
to
c1e7b1b
Compare
pedroargento
approved these changes
Sep 15, 2023
|
This feature has been postponed to v2, as it can much appreciate from the output unification effort. |
ZzzzHui
reviewed
Nov 1, 2023
| // assert the counter starts as 0 | ||
| assertEq(counter.get(), 0); | ||
|
|
||
| // try to execute voucher 1 and fail |
There was a problem hiding this comment.
should be voucher 2, right?
| abi.encodeWithSelector( | ||
| ComplexVouchers.checkIfVoucherWasExecuted.selector, | ||
| dapp, | ||
| 7, |
There was a problem hiding this comment.
probably better using uint256(OutputName.IncVoucher) rather than number 7
|
|
||
| success = executeVoucher(voucher, proof); | ||
| assertEq(success, false); | ||
|
|
There was a problem hiding this comment.
could add assertEq(counter.get(), 0); here
| assertEq(success, false); | ||
|
|
||
| rewind(2 hours); | ||
|
|
There was a problem hiding this comment.
could add assertEq(counter.get(), 0); here
| success = executeVoucher(voucher, proof); | ||
| assertEq(success, true); | ||
|
|
||
| assertEq(address(complex).balance, 0); |
There was a problem hiding this comment.
I'm curious about this line. Should we check balance?
|
@ZzzzHui This PR is blocked by the |
|
We'll have to rewrite this using the to-be-implemented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59