Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of the word VOUCHER in this context may cause confusion. #53

Closed
mpolitzer opened this issue Apr 26, 2024 · 0 comments · Fixed by #51
Closed

Use of the word VOUCHER in this context may cause confusion. #53

mpolitzer opened this issue Apr 26, 2024 · 0 comments · Fixed by #51
Assignees
@mpolitzer
Labels
enhancement New feature or request

Comments

@mpolitzer
Copy link
Collaborator

The name voucher may cause confusion in this context since it has a specific signature for the rollup.
Use generic, different names instead, such that we don't need to keep these tests in sync. We already have rollup tests for that.

https://github.com/cartesi/machine-emulator-tools/blob/main/sys-utils/libcmt/tests/abi-multi.c#L26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpolitzer mpolitzer

Labels
enhancement New feature or request
Projects
Machine Emulator SDK
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make error codes uniform and improve code coverage of libcmt cartesi/machine-emulator-tools
1 participant
@mpolitzer