make error codes uniform and improve code coverage of libcmt #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpolitzer
force-pushed
the
fix/cov
branch
5 times, most recently
from
a3827c3
to
ecdd0cd
Compare
mpolitzer
changed the title
refactor: move read/write file to util - remove unreachable if block
edubart
previously approved these changes
May 2, 2024
mpolitzer
force-pushed
the
fix/cov
branch
2 times, most recently
from
76c2327
to
79018d1
Compare
alexmikhalevich
approved these changes
May 4, 2024
edubart
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #52
close #53
rewrite merkle save/load in terms of read_whole_file and write_whole_file.
after this PR (updated):
missing lines are mostly malloc and stdlib failure branches.
To reproduce the graph above: Add
--coverageto CFLAGS and run: