New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve on the return values of `innerTournamentWinner` call #7

Open

stephenctw opened this issue Dec 22, 2023 · 0 comments

Assignees

Labels

Contributor

stephenctw commented Dec 22, 2023

The call should be able to reflect the state of the tournament correctly, being one of the three below:

Tournament not finished.
Tournament finished, no one won (parent can delete parent match).
Tournament finished, here's the winner.

@return (bool, Tree.Node, Tree.Node)

The return values could be:

(false, zeroNode, zeroNode)
(true, zeroNode, zeroNode)
(true, winnerParentCommitment, winnerCommitment)

Currently we handled (1) and (3), missing (2). @GCdePaula do you think the return values of (2) above makes sense?

The text was updated successfully, but these errors were encountered:

stephenctw added the enhancement label

stephenctw self-assigned this

stephenctw mentioned this issue

new clock implementation and tests #1

Merged

guidanoli mentioned this issue

Deal with tournaments with no winners #22

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment