-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
03-packaging-installing: Improving episode. #77
Comments
You shouldn't be in the conversion directory, but in the top level directory. Can you address moving pip in a separate PR from other changes? |
I agree. However, the episode states:
Since the
This is fixed by running the command
Sure, will do. Edit: apparently the |
- Related to carpentries-incubator#77 - Fixes the sequence of commands (does not return errors anymore) and improves the explanation of the init file.
ahhh, sorry. this got changed a couple of times and I hadn't read carefully. I think the goal should be to first introduce importing a function from a module while in the same directory, without adding a path. So, from
then add more functions, try to import from the top level, see that you need something more and introduce install. I know that we can add to path without installing, but i think that's a suboptimal thing and we should skip that versino. |
I pushed #78 addressing the observations from the last comment. This StackOverflow issue explains the reasons for the errors (it is necessary to use local imports). Edit: thanks for the quick reply. It seems we commented at practically the same time :) |
Hi,
there are some things I'd suggest to improve Ep03:
- Fix the ModuleNotFoundError
If I run the code in the current version of Episode 03, when I run the following line:
Assuming I'm in the
conversions/
directory as instructed, I get the following error:This does work, if I'm in the
conversions/
directory:Not entirely sure if I am doing anything wrong.
If I open a Python terminal from the parent directory of
conversions
and runimport sys; sys.path.append('conversions')
, which is explained earlier in the episode, I can run the imports as they are currently displayed (from conversions import temperature, speed
).- Move the Pip section to somewhere else in the Episode
As described in #58, the Pip section seems a bit out of place. I'd suggest moving it somewhere else in the Episode.
I will document other things I find in this issue. May I submit a PR to address these two points in the meantime?
The text was updated successfully, but these errors were encountered: