Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resources for images (Biocontainers, Bioconda) #165

Open
joelnitta opened this issue Nov 30, 2021 · 4 comments
Open

Add resources for images (Biocontainers, Bioconda) #165

joelnitta opened this issue Nov 30, 2021 · 4 comments
Labels
type:enhancement Propose enhancement to the lesson

Comments

@joelnitta
Copy link

In the Finding containers on dockerhub lesson, there is no mention of any source of images other than Docker Hub. In fact, learners might get the impression that Docker Hub is the only online source for images.

There are at least two additional sources that are worth mentioning: Bioconda and Biocontainers. Since all Bioconda packages have a corresponding Biocontainer image, they are largely overlapping, but they each have their own search interface. The good thing about these sources is that they are all vetted and versioned, so they are generally more reliable than any "random" image you might find on Docker Hub.

@vbagadia
Copy link

I wanted to highlight what @joelnitta stated about "vetted and versioned" images and question whether directions/warnings should be more bold about image selection? Included in hello-world example?

Episode Finding Containers Images on Docker Hub does a good job explaining what to look for and what not to look for when selecting an image. Perhaps worth adding to the key points?

@joelnitta
Copy link
Author

Thanks for the comment! Can you explain a bit more what you mean by "Included in hello-world example?" ?

@vbagadia
Copy link

To clarify, the hello-world example given in Episode Exploring and Running Containers has a user pull an image from the docker hub early on in the lesson and promises a description of docker hub later on in the lesson. When teaching this lesson, and particularly when running docker pull commands, I am suggesting an emphasis be put on verifying images before use.

@joelnitta
Copy link
Author

joelnitta commented Jan 18, 2022

I see, thanks for clarifying.

IMHO the order is OK... of all images, the "hello world" image provided by Docker should be secure, and it would be a pretty big detour at that point to go into the details of Docker Hub. I think emphasis on using images from trusted sources is fine, but the actual lesson order doesn't need to change.

@sstevens2 sstevens2 added the type:enhancement Propose enhancement to the lesson label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Propose enhancement to the lesson
Projects
None yet
Development

No branches or pull requests

3 participants