Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document multiparameter patern. #1020

Open
carltongibson opened this issue Dec 17, 2018 · 1 comment · May be fixed by #1167
Open

Document multiparameter patern. #1020

carltongibson opened this issue Dec 17, 2018 · 1 comment · May be fixed by #1167

Comments

@carltongibson
Copy link
Owner

You need to filter on more that one parameter? Use a multi-widget to have all values passes as one to a single filter.

  • Document this with an example.
  • Does it merit a helper class?

c.f. #977 (comment)
@carltongibson carltongibson mentioned this issue Dec 17, 2018
Closed
@rpkilby
Copy link
Collaborator

rpkilby commented Feb 19, 2019

Note that this isn't fully compatible with API use. e.g., take the range* multi filters. The actual query params have after and before suffixes, however validation errors are raised under the unsuffixed filter name. There is no way to distinguish which sub-param the error applied to.

The multi-widget incompatibility should also be documented in the DRF integration section.

@rpkilby rpkilby linked a pull request Jan 28, 2020 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add group validation & filtering rpkilby/django-filter
2 participants
@carltongibson @rpkilby