Return empty array when query param doesn't match record instead of "Select a valid choice. That choice is not one of the available choices."

[cheslijones]

I have a URI like the following:

/api/d2u/?document_guid=df4c9c11-49dd-ec11-a7b6-000d3a3667a1

There are no records in the corresponding table that match that query param. My expectation is that it would return:

[]

But instead it returns:

{
  "document_guid": [
    "Select a valid choice. That choice is not one of the available choices."
  ]
}

I'm just curious: can this behavior can be modified in django-filter or if this should be handled with error response handling in the views.py in DRF/Django?

# views.py
class Document2UserSyncViewSet(viewsets.ModelViewSet):
    filter_backends = [DjangoFilterBackend]
    filter_fields = [
        'id',
        'document_guid',
        'user_guid'
    ]
    permission_classes = [PowerAutomatePermissions]
    queryset = Document2User.objects.all().order_by('id')
    serializer_class = Document2UserSerializer

# serializer.py
class Document2UserSerializer(serializers.ModelSerializer):
    class Meta:
        model = Document2User
        fields = '__all__'

# models.py
class Document2User(models.Model):
    document_guid = models.ForeignKey(
        Documents,
        to_field='guid',
        on_delete=models.CASCADE,
        db_column='document_guid'
    )
    user_guid = models.ForeignKey(
        CRMFields,
        to_field='guid',
        on_delete=models.CASCADE,
        db_column='user_guid'
    )
    created = models.DateTimeField(auto_now_add=True)
    updated = models.DateTimeField(auto_now=True)

    class Meta:
        db_table = 'document_to_user'
        unique_together = [['user_guid', 'document_guid']]

[carltongibson]

You can do something like this:

class StrictDjangoFilterBackend(django_filters.rest_framework.DjangoFilterBackend):
    """Return no results if the query doesn't validate."""

    def filter_queryset(self, request, queryset, view):
        try:
            return super().filter_queryset(request, queryset, view):
        except serializers.ValidationError:
            return queryset.none()

See #788 (comment) and surrounding comments.

[cheslijones]

Thank you, that did the trick!