Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛟 for fault tolerance related code #1634

Open
4 tasks done
agea opened this issue Nov 23, 2023 · 5 comments
Open
4 tasks done

🛟 for fault tolerance related code #1634

agea opened this issue Nov 23, 2023 · 5 comments
Labels
emoji Gitmoji proposals.

Comments

@agea
Copy link
Contributor

agea commented Nov 23, 2023

Emoji symbol

🛟

Emoji code

🛟

Emoji description

Code related to fault tolerance

Describe the use case of your emoji

Code used to prevent and manage errors, eg: retrying failed requests, rate limiting, concurrency limiting

Is this use case covered by an existing emoji?

No ❌

Does this emoji fall into the "how" or the "what" category?

  • This proposal do not describe "how" a commit was made, but does in fact describe "what" is the contents of the commit about.

Examples

using this library is a good example:

https://smallrye.io/docs/smallrye-fault-tolerance/6.2.6/index.html

Validations

@agea agea added the emoji Gitmoji proposals. label Nov 23, 2023
@cruzdanilo
Copy link

i think this is already covered by 🥅 (catch errors).

@agea
Copy link
Contributor Author

agea commented Nov 23, 2023

Maybe it's a subtle difference, usually in "catch error" commits, there is a try/catch clause explicitly catching errors

In this case, you wouldn't have a try/catch; instead, for instance, by adding a rate or concurrency limiter, you would generate exceptions

@mingjunlu
Copy link
Contributor

I'm also wondering which emoji to use for adding a rate limit 🤔

@vhoyer
Copy link
Collaborator

vhoyer commented Dec 5, 2023

Hmm, I'm with @cruzdanilo, maybe we could change the description from catching errrors to also include the meaning to fault tolerance, what do you all think of "catch, prevent and manage errors"?

@mingjunlu
Copy link
Contributor

@vhoyer Sounds good to me! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emoji Gitmoji proposals.
Projects
None yet
Development

No branches or pull requests

4 participants