-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for 0.12.0 release #360
Comments
One more thing. The main branch should be linearized before being added to the repository by rebasing The repository should be configured to only allow fast-forward, no merges. |
Thinking more about it, the problematic commits should not go to the main branch, they should go to PRs and stay there until they are fixed. |
Done so far:
My private fork of cargo2nix is identical to the What needs to be done:
|
Do you need extra rights on this repository? |
I cannot change the default branch and protect branches. Please either do it for me or give me permission to do it. It's not good to have an unprotected main branch. I don't think I can make releases, but we are not at that point yet. I cannot merge PRs without approval. That's OK for now, as I'm getting approvals quickly. It could be a problem if everyone else walks away and stop looking at the PRs. |
I realize that cargo2nix may be getting obsoleted by other tools. However, it's users still can get a better experience. There is a lot of good code in cargo2nix, but it's not on the right branches and not in the right releases.
I maintain an internal fork of cargo2nix that reverts 4 commits that break my company's project:
2ae2f57 (this only breaks cross-compilation)
79cd412
807d916
a2ab864 (those 3 are related and interdependent)
It took me a while (days!) to identify those while also dealing with easily fixable issues (old Rust, attempts to access network, irrelevant warnings etc).
If the recent changes to cargo get into stable, that would put most cargo2nix users in a similar situation, i.e. they would have to maintain an internal fork or switch to another solution (crane, crate2nix etc).
What's wrong with cargo2nix now:
release-0.11
0.11.0
This could be done to mitigate the situation without spending too much time:
release-0.11.0
branch tomain
that becomes the main branch for developmentmain
branchrelease-0.12
branch based on thev0.11.0
tagmain
except the commits I mentionedv0.12.0
release-0.12
branch only for simple changes cherry-picked frommain
The text was updated successfully, but these errors were encountered: