Fix #348 for cross-compiling onto mingw-w64. #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psionic-k
reviewed
Mar 8, 2024
| @@ -1,8 +1,9 @@ | |||
| [package] | |||
| name = "hello-world" | |||
| version = "0.1.0" | |||
| authors = ["Eyal Kalderon <eyal.kalderon@tenx.tech>"] | |||
| authors = ["gjz010 <gjz010@gjz010.com>"] | |||
There was a problem hiding this comment.
Author should not be changed.
There was a problem hiding this comment.
It is a brand new test case that I added to test calling Win32 API through winapi and windows_rs crates. I will revert the change if you prefer that.
There was a problem hiding this comment.
Oh never mind. I must have looked at the individual commit and not the whole change set.
Thanks for changes. I'm currently back in the thick of deployment work and likely to do some overdue work here, including merging changes like these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #348 (comment) .
A new cross-compiling example is added for reference.
Pull Requests
Many files are generated. When you draft your changes, please separate out
commits that affect:
Keeping these changes isolated in specific commits makes it much easier to pull
in your changes in parallel with other features. Maintainers may harvest your
changes. We only guarantee to preserve authorship in the git log (when we
remember to do so).
Creating pull requests
for breaking changes
changes applied with authorship preserved (if we remember)