Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show pool ID in created by field #355

Open
AndrewWestberg opened this issue Sep 8, 2020 · 1 comment · Fixed by #364
Open

Show pool ID in created by field #355

AndrewWestberg opened this issue Sep 8, 2020 · 1 comment · Fixed by #364
Labels
enhancement New feature or request

Comments

@AndrewWestberg
Copy link

block 4662295 in epoch 216, slot 1103 was created by my pool BCSH1. In the explorer, this is listed as created by 7dbe27e. I don't know what this value is, but it's not the pool id. My pool id is:

00beef9385526062d41cd7293746048c6a9a13ab8b591920cf40c706
@rhyslbw rhyslbw changed the title Block explorer shows wrong poolId in created by field Block explorer doesn't show pool ID in created by field Sep 10, 2020
@rhyslbw rhyslbw changed the title Block explorer doesn't show pool ID in created by field Show pool ID in created by field Sep 10, 2020
@rhyslbw rhyslbw added the enhancement New feature or request label Sep 10, 2020
@rhyslbw
Copy link
Collaborator

rhyslbw commented Sep 10, 2020

It's currently showing the slot leader identifier, but there's an update in progress to refer to pools if the block was created by one. I've reformatted this issue as a feature request

@rhyslbw rhyslbw modified the milestone: 1.2.0 Sep 17, 2020
rhyslbw added a commit that referenced this issue Sep 22, 2020
@rhyslbw
feat: use stake pool hash over slot leader reference
bfdc921 
when a block is created by a stake pool, the pool hash is now used. BFT
nodes still use the slot leader reference

Closes #355
@rhyslbw rhyslbw removed this from the 1.2.0 milestone Sep 22, 2020
@rhyslbw rhyslbw mentioned this issue Sep 22, 2020
Merged
rhyslbw added a commit that referenced this issue Sep 22, 2020
@rhyslbw
feat: use stake pool hash over slot leader reference
0f345dd 
when a block is created by a stake pool, the pool hash is now used. BFT
nodes still use the slot leader reference

Closes #355
@rhyslbw rhyslbw reopened this Sep 29, 2020
@rhyslbw rhyslbw reopened this Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use stake pool hash over slot leader reference cardano-foundation/cardano-explorer-app
2 participants
@AndrewWestberg @rhyslbw