Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP - prototype - DO NOT MERGE] Single Level Reprojection #79

Closed
wants to merge 2 commits into from
Closed

[WIP - prototype - DO NOT MERGE] Single Level Reprojection #79

wants to merge 2 commits into from

Conversation

norlandrhagen
Copy link
Contributor

@norlandrhagen norlandrhagen commented Dec 8, 2023 •
edited by andersy005

This PR intends to add the ability for ndpyramid to create individual pyramid levels.

  • Refactor the internals of pyramid_reproject for shared use
  • Create function for single level creation
  • Fixes Specify levels #74

Performance improvement ideas:

  • remove for loop and map over levels
  • 'fast path' option to generate levels from successive levels
  • generate weights to pass to XESMF
  • xr.map_blocks over non spatial dims

cc @maxrjones @andersy005 feel free to add/edit this list.

@norlandrhagen
Copy link
Contributor Author

Pushed a temp version of this for testing out pangeo-forge StoreToZarr. Super messy and duplicated functionality. Needs major refactor etc. before thinking of merging.

@norlandrhagen norlandrhagen changed the title [WIP] Single Level Reprojection [WIP - prototype - DO NOT MERGE] Single Level Reprojection Dec 12, 2023
@maxrjones
Copy link
Member

Thanks @norlandrhagen! I can work on the refactoring, but it seems like the temporary function will be sufficient for testing out StoreToZarr - is that interpretation accurate?

@norlandrhagen
Copy link
Contributor Author

@maxrjones I think so!

@maxrjones
Copy link
Member

@norlandrhagen mind if we close this in favor of #84?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify levels
2 participants
@norlandrhagen @maxrjones