Skip to content
This repository has been archived by the owner on Feb 5, 2024. It is now read-only.

IE11: Issues with gatsby-mdx move #1292

Closed
2 of 3 tasks
asudoh opened this issue Mar 12, 2019 · 10 comments
Closed
2 of 3 tasks

IE11: Issues with gatsby-mdx move #1292

asudoh opened this issue Mar 12, 2019 · 10 comments

Comments

@asudoh
Copy link
Contributor

asudoh commented Mar 12, 2019

Brief description

Found the following issues, causing the user-facing issue described below:

Detailed description

Describe in detail the issue you're having.

next.carbondesignsystem.com is not interactive with IE11.

Is this issue related to a specific component?

No

What did you expect to happen? What happened instead? What would you like to see changed?

e.g. Side nav in the site is interactive.

What browser are you working in?

IE11

What version of the Carbon Design System are you using?

next.carbondesignsystem.com

@vpicone
Copy link
Contributor

vpicone commented Mar 25, 2019

Is there a reason we're doing this global scope thing as opposed to just importing the necessary components into the mdx files?

@asudoh
Copy link
Contributor Author

asudoh commented Mar 26, 2019

@vpicone Is your question to some of my comments above or of a specific code...? 🤔

@vpicone
Copy link
Contributor

vpicone commented Mar 26, 2019

@asudoh I was wondering if importing the components at the top of the mdx files would fix the double bundling issue and include the appropriate polyfills.

@asudoh
Copy link
Contributor Author

asudoh commented Mar 26, 2019

@alisonjoseph Thoughts...? Thanks!

@josefaidt
Copy link
Contributor

@asudoh and @vpicone I've been looking into this and can't get the sidebar to work in v9 either using IE11. For me it doesn't work in v9 or v10 on IE11. For clarification the interactiveness you are looking for is when clicking content categories the item should expand to show its pages?

I added the polyfills to the MDX global scope and it does fix some issues with MDX pages like "Resources", but the sidebar is still broken.

@stale
Copy link

stale bot commented Apr 24, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.

@stale stale bot added the wontfix label Apr 24, 2019
@aledavila
Copy link
Contributor

@asudoh Commenting so this issue doesn’t close. Is there any update on this. The issue persists in www site now

@stale stale bot removed the wontfix label Apr 24, 2019
@asudoh
Copy link
Contributor Author

asudoh commented Apr 24, 2019

@alisonjoseph Do you think you'd have a chance to get in touch with Gatsby team on this, given the issue need Gatsby's internal knowledge for resolution? Thanks!

@vpicone
Copy link
Contributor

vpicone commented Apr 25, 2019

@asudoh looks like this was fixed with carbon-design-system/carbon-website#1504 checked with Edge and IE 11

We were importing our React library before the page component with the polyfills. We could have included the polyfills at the gatsby ssr/browser config level, but this works as well.

@vpicone vpicone closed this as completed Apr 25, 2019
@asudoh
Copy link
Contributor Author

asudoh commented Apr 25, 2019

Good to hear - Thanks alot @vpicone for checking!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants