Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaped "/"s in url are not handled correctly #3

Open
captbaritone opened this issue Sep 4, 2015 · 4 comments
Open

Escaped "/"s in url are not handled correctly #3

captbaritone opened this issue Sep 4, 2015 · 4 comments

Comments

@captbaritone
Copy link
Owner

It looks like Flask hands them to me already escaped, so I can't tell the difference...

@hanndull
Copy link

hanndull commented Apr 1, 2019

If flask hands it over to the program already escaped, how does the program prompt the translucent "error" layer that gets added over the top of the meme?

Screen Shot 2019-04-01 at 11 26 28 AM

@hanndull
Copy link

hanndull commented Apr 1, 2019

(also, this is Hannah)

@captbaritone
Copy link
Owner Author

Hey! The overlay is actually a loading overlay. I think what’s happening is we are getting an error (404?) back from the server because the url does not match any of the declared routes. Then, the front end code never handles the error case. So, it goes into the loading state, and starts waiting for the successful loading of the image. But, since the image fails to load, we never get the event that tells us that the image loaded, and we (the front end code) gets stuck.

That’s all on the front end (JavaScript). I’m not sure why the Flask server errors when you type in that url. If you can get the app running locally (pip install can be a real pain to get setup) then you might see a helpful error in the cli when you try to load that image with the extra slashes.

@captbaritone
Copy link
Owner Author

I’ve filed a separate issue for the error handling on the front end: #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants