Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serve an image on error #28

Open
captbaritone opened this issue Mar 28, 2019 · 1 comment
Open

Serve an image on error #28

captbaritone opened this issue Mar 28, 2019 · 1 comment

Comments

@captbaritone
Copy link
Owner

I broke images yesterday (deleted the cache directory in addition to its contents when I tried to free up some disk space on the server). They were returning 500 which was probably confusing for any place that they are embedded.

We should catch errors thrown in the image generation path and return a special 500 image if it fails.
@captbaritone
Copy link
Owner Author

captbaritone commented Apr 2, 2019 •
edited

We are actually already doing this when imgur images fail to get created. We should expand it to all error responses ending in png/jpg/jpeg/gif. Ideally by serving a static image rather than generating one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@captbaritone