Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce console output #5

Open
aleksblendwerk opened this issue May 1, 2020 · 4 comments
Open

Reduce console output #5

aleksblendwerk opened this issue May 1, 2020 · 4 comments
Assignees

Comments

@aleksblendwerk
Copy link

aleksblendwerk commented May 1, 2020

ARRRR! Using this plugin, the Cap'n is a bit too talkative for me - it would be nice to have a way to not hear anything from him (including the CaptainHook Composer Plugin line) or only hear from him when something has actually been done within a call of composer update or install.

It's probably just one of my weird OCD symptoms but I would prefer if there is no output when it just reports that all of the hooks are already installed - it just weirds me out a bit having so much additional output after an ordinary composer update.

Maybe this could be done by setting an option in the extra section of composer.json with a few different values, among them one that will never output anything and one that will only output stuff when there have actually been any changes to the actual hooks.

@sebastianfeldmann
Copy link
Contributor

Sounds doable, I'll have a look at it

@sebastianfeldmann
Copy link
Contributor

sebastianfeldmann commented May 1, 2020

The captainhook install command does currently not abide to the captainhook.json verbosity setting.

Would it be suffice for you if that would be the case so you could configure verbosity there?

This is my composer update output after fixing it locally and setting the Captains verbosity to quiet ?

$ composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 0 updates, 0 removals
Generating autoload files
5 packages you are using are looking for funding.
Use the composer fund command to find out more!
CaptainHook Composer Plugin
  Using CaptainHook config: /Users/sf/Development/github.com/captainhook/captain-install plugin/captainhook.json

@sebastianfeldmann sebastianfeldmann self-assigned this May 1, 2020
@aleksblendwerk
Copy link
Author

aleksblendwerk commented May 1, 2020

If it's up to me I'd rather have no output at all when the plugin calls the install command and no changes are done to the hook files.

If I am getting this right if I set the verbosity setting in the config to quiet, the actual hook actions don't output anything any more either and just silently fail. That's not what I'd want it to do.

Sorry for being such a pain... :)

Maybe the verbosity of the plugin should be configurable in the extra section of composer.json instead, same as the already existing plugin options?

@sebastianfeldmann
Copy link
Contributor

No pain at all, I totally get it. I will think about it a bit more and see what I can come up with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants