Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#1431] Implement HTMLTimeElement #1432

Merged
merged 2 commits into from May 14, 2024

Conversation

r-thomson
Copy link
Contributor

Implements the HTMLTimeElement type. Closes #1431

Please let me know if I’ve missed anything here

@r-thomson
Copy link
Contributor Author

Not sure why tests are failing on this one, it looks unrelated to my changes (unless I'm missing something)

Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @r-thomson! 🌟

@capricorn86 capricorn86 merged commit f0d6091 into capricorn86:master May 14, 2024
3 checks passed
@capricorn86
Copy link
Owner

Not sure why tests are failing on this one, it looks unrelated to my changes (unless I'm missing something)

There are some time based tests that are failing from time to time. They need to be fixed, but it has gotten less priority compared to other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTMLTimeElement is not implemented
2 participants