Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsDisconnected not working on real server disconnect #527

Open
jwang-r7 opened this issue Jun 15, 2023 · 1 comment
Open

IsDisconnected not working on real server disconnect #527

jwang-r7 opened this issue Jun 15, 2023 · 1 comment
Labels

Comments

@jwang-r7
Copy link

IsDisconnected works when calling conn.Close(). However, when killing the server it's connected to in a real scenario doesn't seem to return the same.

I have seen it return:

  • ErrConnClosed
  • Named pipe file closed from the library that I'm using

Not sure if it will return ExcClosed at any point.

f, release = myclient.MyMethod(ctx, func(ps rpc_api.Params) error {
		// Some CB
               return nil
	})
val, err := f.Struct() // catching connection err
@zenhack
Copy link
Contributor

zenhack commented Jun 16, 2023

I will hazard a guess that we have code that is handling message send failures by just propagating the error returned by the transport; probably to fix this we need to update those call sites to wrap the error.

@zenhack zenhack added the bug label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants