Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I have no idea what my reasoning was with this comment, but it makes no sense as a justification, since either way the probability of choosing other branches of the select is non-zero. #447

Open
zenhack opened this issue Feb 9, 2023 · 0 comments

Comments

@zenhack
Copy link
Contributor

zenhack commented Feb 9, 2023

          I have no idea what my reasoning was with this comment, but it makes no sense as a justification, since either way the probability of choosing other branches of the select is non-zero.

I want to stare at this a bit more; I wonder if there's some bookkeeping that I knew we needed to be doing here, but apparently failed at actually ensuring we did? I'll have to have a look when we revisit fixing the estimation problems.

Originally posted by @zenhack in #446 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant