Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: tease apart method lookup & server processing. #409

Open
zenhack opened this issue Dec 29, 2022 · 0 comments
Open

Cleanup: tease apart method lookup & server processing. #409

zenhack opened this issue Dec 29, 2022 · 0 comments
Labels
Milestone

Comments

@zenhack
Copy link
Contributor

zenhack commented Dec 29, 2022

Per discussion in #400 and #405, it would be nice to refactor the sever package a bit, so that method handling is encapsulated in an interface like:

type MethodHandler interface {
    HandleMethod(context.Context, capnp.Method, *Call)
}

...and looking up the particular method in a slice or whatnot is an implementation detail of serverMethods's implementation of HandleMethod(). Low priority, since it's mostly a cleanup thing, but I'd like to do this before we tag 3.0 and thus can't make breaking changes.

@zenhack zenhack added this to the 3.0 milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant