Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSegmentArena: avoid footguns with sync.Pool #351

Open
zenhack opened this issue Nov 27, 2022 · 0 comments
Open

MultiSegmentArena: avoid footguns with sync.Pool #351

zenhack opened this issue Nov 27, 2022 · 0 comments

Comments

@zenhack
Copy link
Contributor

zenhack commented Nov 27, 2022

Per @lthibault comment, we should consider whether we can/should make our use of sync.Pool for MultiSegment harder to misuse; for an rpc workload messages are likely to be of similar, reasonable sizes, but other users of the library might have some large messages that we may not want to keep in the pool for memory use reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant