BufferedInputStreamWrapper::tryRead fails on EOF

[alexrobomind]

Currently, the implementation of BufferedInputStreamWrapper::tryRead will throw on premature EOF due to forwarding to InputStream::read if the buffer is insufficient to fill the request:

capnproto/c++/src/kj/io.c++

Line 156 in 737dba8

size_t n = inner.read(buffer.begin(), minBytes, buffer.size());

capnproto/c++/src/kj/io.c++

Line 164 in 737dba8

return fromFirstBuffer + inner.read(dst, minBytes, maxBytes);

Wouldn't it make more sense to forward the read requests to InputStream::tryRead instead?

[kentonv]

Looks like this bug was introduced in 227a491 when tryRead() was introduced and this implementation of read() was renamed to tryRead() without looking carefully enough at the details.

And that was 11 years ago, and no one ever noticed, I guess...