Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI job for latest SQLite, libuv, liblz4 #630

Merged
merged 3 commits into from May 22, 2024

Conversation

cole-miller
Copy link
Contributor

Closes #565

Signed-off-by: Cole Miller cole.miller@canonical.com

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.43%. Comparing base (cb65db7) to head (07b586f).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
- Coverage   80.57%   77.43%   -3.15%     
==========================================
  Files         196      196              
  Lines       28301    27232    -1069     
  Branches     5300     5475     +175     
==========================================
- Hits        22803    21086    -1717     
- Misses       3767     4352     +585     
- Partials     1731     1794      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cole-miller cole-miller changed the title Add CI job for latest SQLite, libuv Add CI job for latest SQLite, libuv, liblz4 Mar 11, 2024
@cole-miller
Copy link
Contributor Author

I took the opportunity to also fix --enable-build-sqlite to not require spamming #pragma GCC diagnostic ignored :) now it should really be as simple as dropping the amalgamation into the dqlite source root.

The new job gets the latest libuv release by parsing https://dist.libuv.org (which is clearly designed to be machine-readable), and the latest SQLite release by following the helpful instructions here. lz4 just does GitHub releases so I fell back to good old git tag | sort -V -r.

@cole-miller cole-miller marked this pull request as draft March 12, 2024 14:51
@cole-miller
Copy link
Contributor Author

I don't know what's going on with the segfaults but marking as draft for now just to be safe

@cole-miller cole-miller reopened this Mar 12, 2024
@cole-miller cole-miller marked this pull request as ready for review April 24, 2024 09:46
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
Signed-off-by: Cole Miller <cole.miller@canonical.com>
@cole-miller
Copy link
Contributor Author

Ready to go!

@cole-miller cole-miller merged commit e435f5d into canonical:master May 22, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run dqlite tests against most recent SQLite release.
1 participant