Raft uv_timer leak when creating and destroying node

[MathieuBordere]

src/server.c:176: dqlite__close: Assertion 'rv == 0' failed.

Reported by @stgraber, see failures here https://jenkins.linuxcontainers.org/job/lxd-github-commit/4903/

It's related to a TODO . This timer is not properly closed when only calling dqlite_node_create and dqlite_node_destroy without starting and stopping the node. This sequence of calls is hit in the node recovery logic, where we explicitly don't want to run the node and made visible by the newly introduced assert in this change that asserts the rv of uv_loop_close.

I will remove the newly introduced assert to fix the LXD test suite and track the proper fix in this issue.

[MathieuBordere]

Additionally, the sequence dqlite_node_create, dqlite_node_set_bind_address, dqlite_node_destroy will lead to triggering the assertion because the listener handle here

dqlite/src/server.c

Line 247 in c3ac4d8

rv = transport__stream(&t->loop, fd, &t->listener);

is still active.