Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix e2e, a11y and visual tests for Operate #18586

Merged
merged 6 commits into from
May 16, 2024

Conversation

pedesen
Copy link
Contributor

@pedesen pedesen commented May 16, 2024

Description

After #18248 got automerged, a11y and visual regression tests started to fail. This PR cleans it up and fixes the tests.

To fix a11y tests:

  • exclude unused DRD search input from a11y tests

To fix visual regression tests:

  • bump @carbon/elements and @carbon/react to resolve issues relaated to react 18.3.x
  • visual regression snapshots have been updated, because of expected changes in Carbon:
    • modal visuals changed
    • icon button position changed
    • close button position changed
    • clear combobox button position changed
    • "more filters" button focus border
    • accordion paddings change

To fix e2e tests:

  • add env var to disable CSRF for tests

additional fixes

  • fix several test selectors

@github-actions github-actions bot added the component/operate Related to the Operate component/team label May 16, 2024
@pedesen pedesen force-pushed the fe-fix-a11y-and-visual-tests branch from fd32d57 to b90790c Compare May 16, 2024 14:11
@pedesen pedesen changed the title fix: fix a11y and visual tests for Operate fix: fix e2e, a11y and visual tests for Operate May 16, 2024
@pedesen pedesen force-pushed the fe-fix-a11y-and-visual-tests branch from b90790c to b5c87c4 Compare May 16, 2024 14:23
@pedesen pedesen marked this pull request as ready for review May 16, 2024 14:57
@pedesen pedesen enabled auto-merge May 16, 2024 14:57
@pedesen pedesen merged commit f143379 into stable/operate-8.5 May 16, 2024
19 checks passed
@pedesen pedesen deleted the fe-fix-a11y-and-visual-tests branch May 16, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/operate Related to the Operate component/team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants