Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move Tasklist's Application class to dist #18555

Merged
merged 7 commits into from
May 17, 2024
Merged

refactor: move Tasklist's Application class to dist #18555

merged 7 commits into from
May 17, 2024

Conversation

houssain-barouni
Copy link
Collaborator

@houssain-barouni houssain-barouni commented May 15, 2024 •
edited

Description

  • Move the Tasklist main Application class to the dist module
  • Rename the Application class to StandaloneTasklist
  • Adjusts Tasklist's Makefile to ensure that the development environment continues to work

Related issues

relates to #18535

@github-actions github-actions bot added component/zeebe Related to the Zeebe component/team component/operate Related to the Operate component/team component/tasklist Related to the Tasklist component/team labels May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited

Operate Test Results

798 tests   795 ✅  7m 50s ⏱️
132 suites    3 💤
132 files      0 ❌

Results for commit 01c1855.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2024 •
edited

Tasklist Test Results

143 files  ± 0  143 suites  ±0   1h 18m 11s ⏱️ - 15m 38s
549 tests ± 0  544 ✅ ± 0  5 💤 ±0  0 ❌ ±0 
531 runs   - 18  526 ✅  - 18  5 💤 ±0  0 ❌ ±0 

Results for commit 949ec3a. ± Comparison against base commit e7dcdf2.

This pull request removes 13 and adds 13 tests. Note that renamed tests count towards both. 
io.camunda.tasklist.webapp.api.rest.v1.controllers.external.ProcessExternalControllerTest ‑ startProcessWithEmbeddedForm(HttpStatus, String, ProcessEntity, ProcessInstanceDTO)[1] expectedHttpStatus=200 OK, bpmnProcessId=StartProcessByForm, processEntity=TenantAwareTasklistEntity[id='1', tenantId='<default>'], providedProcessInstanceDTO=io.camunda.tasklist.webapp.graphql.entity.ProcessInstanceDTO@724154fa
io.camunda.tasklist.webapp.api.rest.v1.controllers.external.ProcessExternalControllerTest ‑ startProcessWithLinkedForm(HttpStatus, String, ProcessEntity, ProcessInstanceDTO)[1] expectedHttpStatus=200 OK, bpmnProcessId=StartProcessByForm, processEntity=TenantAwareTasklistEntity[id='1', tenantId='<default>'], providedProcessInstanceDTO=io.camunda.tasklist.webapp.graphql.entity.ProcessInstanceDTO@adae5384
io.camunda.tasklist.webapp.security.sso.AuthenticationIT ‑ testLoginAndUsageOfGraphQlApi(BiFunction)[1] orgExtractor=io.camunda.tasklist.webapp.security.sso.AuthenticationIT$$Lambda/0x00007d17dd1b8f60@793e92fc
io.camunda.tasklist.webapp.security.sso.AuthenticationIT ‑ testLoginAndUsageOfRestApi(BiFunction)[1] orgExtractor=io.camunda.tasklist.webapp.security.sso.AuthenticationIT$$Lambda/0x00007d17dd1b8f60@793e92fc
io.camunda.tasklist.webapp.security.sso.AuthenticationIT ‑ testLoginFailedWithNoPermissions(BiFunction)[1] orgExtractor=io.camunda.tasklist.webapp.security.sso.AuthenticationIT$$Lambda/0x00007d17dd1b8f60@793e92fc
io.camunda.tasklist.webapp.security.sso.AuthenticationIT ‑ testLoginFailedWithNoReadPermissions(BiFunction)[1] orgExtractor=io.camunda.tasklist.webapp.security.sso.AuthenticationIT$$Lambda/0x00007d17dd1b8f60@793e92fc
io.camunda.tasklist.webapp.security.sso.AuthenticationIT ‑ testLoginSucceedWithNoWritePermissions(BiFunction)[1] orgExtractor=io.camunda.tasklist.webapp.security.sso.AuthenticationIT$$Lambda/0x00007d17dd1b8f60@793e92fc
io.camunda.tasklist.webapp.security.sso.AuthenticationIT ‑ testLoginSuccess(BiFunction)[1] orgExtractor=io.camunda.tasklist.webapp.security.sso.AuthenticationIT$$Lambda/0x00007d17dd1b8f60@793e92fc
io.camunda.tasklist.webapp.security.sso.AuthenticationIT ‑ testLogout(BiFunction)[1] orgExtractor=io.camunda.tasklist.webapp.security.sso.AuthenticationIT$$Lambda/0x00007d17dd1b8f60@793e92fc
io.camunda.tasklist.webapp.security.sso.AuthenticationWithPersistentSessionsIT ‑ testLoginFailedWithNoPermissions(BiFunction)[1] orgExtractor=io.camunda.tasklist.webapp.security.sso.AuthenticationWithPersistentSessionsIT$$Lambda/0x00007b61c128d380@6bc0f4e3
…

io.camunda.tasklist.webapp.api.rest.v1.controllers.external.ProcessExternalControllerTest ‑ startProcessWithEmbeddedForm(HttpStatus, String, ProcessEntity, ProcessInstanceDTO)[1] expectedHttpStatus=200 OK, bpmnProcessId=StartProcessByForm, processEntity=TenantAwareTasklistEntity[id='1', tenantId='<default>'], providedProcessInstanceDTO=io.camunda.tasklist.webapp.graphql.entity.ProcessInstanceDTO@9f694a3
io.camunda.tasklist.webapp.api.rest.v1.controllers.external.ProcessExternalControllerTest ‑ startProcessWithLinkedForm(HttpStatus, String, ProcessEntity, ProcessInstanceDTO)[1] expectedHttpStatus=200 OK, bpmnProcessId=StartProcessByForm, processEntity=TenantAwareTasklistEntity[id='1', tenantId='<default>'], providedProcessInstanceDTO=io.camunda.tasklist.webapp.graphql.entity.ProcessInstanceDTO@fa8a6308
io.camunda.tasklist.webapp.security.sso.AuthenticationIT ‑ testLoginAndUsageOfGraphQlApi(BiFunction)[1] orgExtractor=io.camunda.tasklist.webapp.security.sso.AuthenticationIT$$Lambda/0x0000798cb1223b80@1df48c2
io.camunda.tasklist.webapp.security.sso.AuthenticationIT ‑ testLoginAndUsageOfRestApi(BiFunction)[1] orgExtractor=io.camunda.tasklist.webapp.security.sso.AuthenticationIT$$Lambda/0x0000798cb1223b80@1df48c2
io.camunda.tasklist.webapp.security.sso.AuthenticationIT ‑ testLoginFailedWithNoPermissions(BiFunction)[1] orgExtractor=io.camunda.tasklist.webapp.security.sso.AuthenticationIT$$Lambda/0x0000798cb1223b80@1df48c2
io.camunda.tasklist.webapp.security.sso.AuthenticationIT ‑ testLoginFailedWithNoReadPermissions(BiFunction)[1] orgExtractor=io.camunda.tasklist.webapp.security.sso.AuthenticationIT$$Lambda/0x0000798cb1223b80@1df48c2
io.camunda.tasklist.webapp.security.sso.AuthenticationIT ‑ testLoginSucceedWithNoWritePermissions(BiFunction)[1] orgExtractor=io.camunda.tasklist.webapp.security.sso.AuthenticationIT$$Lambda/0x0000798cb1223b80@1df48c2
io.camunda.tasklist.webapp.security.sso.AuthenticationIT ‑ testLoginSuccess(BiFunction)[1] orgExtractor=io.camunda.tasklist.webapp.security.sso.AuthenticationIT$$Lambda/0x0000798cb1223b80@1df48c2
io.camunda.tasklist.webapp.security.sso.AuthenticationIT ‑ testLogout(BiFunction)[1] orgExtractor=io.camunda.tasklist.webapp.security.sso.AuthenticationIT$$Lambda/0x0000798cb1223b80@1df48c2
io.camunda.tasklist.webapp.security.sso.AuthenticationWithPersistentSessionsIT ‑ testLoginFailedWithNoPermissions(BiFunction)[1] orgExtractor=io.camunda.tasklist.webapp.security.sso.AuthenticationWithPersistentSessionsIT$$Lambda/0x00007d951d3141f8@4340020c
…

♻️ This comment has been updated with latest results.

Base automatically changed from rs-ope-zb-single-application to main May 16, 2024 10:01
@houssain-barouni houssain-barouni marked this pull request as ready for review May 16, 2024 13:22
@github-actions GitHub Actions
Copy link
Contributor

Operate Unit Tests Results

275 tests  ±0   274 ✅ ±0   5m 46s ⏱️ -5s
 44 suites ±0     1 💤 ±0 
 44 files   ±0     0 ❌ ±0 

Results for commit 949ec3a. ± Comparison against base commit e7dcdf2.

@github-actions GitHub Actions
Copy link
Contributor

Operate Integration Tests Results

523 tests  ±0   521 ✅ ±0   6m 53s ⏱️ - 1m 58s
 88 suites ±0     2 💤 ±0 
 88 files   ±0     0 ❌ ±0 

Results for commit 949ec3a. ± Comparison against base commit e7dcdf2.

romansmirnov
romansmirnov approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@romansmirnov romansmirnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite straightforward. LGTM!

@houssain-barouni houssain-barouni added this pull request to the merge queue May 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 17, 2024
@houssain-barouni houssain-barouni added this pull request to the merge queue May 17, 2024
@houssain-barouni houssain-barouni removed this pull request from the merge queue due to a manual request May 17, 2024
@houssain-barouni houssain-barouni added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 5843ba8 May 17, 2024
61 of 62 checks passed
@houssain-barouni houssain-barouni deleted the move_tasklist_application branch May 17, 2024 14:31
@houssain-barouni houssain-barouni mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romansmirnov romansmirnov romansmirnov approved these changes

@Zelldon Zelldon Awaiting requested review from Zelldon

Assignees
No one assigned
Labels
component/operate Related to the Operate component/team component/tasklist Related to the Tasklist component/team component/zeebe Related to the Zeebe component/team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@houssain-barouni @romansmirnov