Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return resource_exhausted when sequencer buffer is full #18548

Merged
merged 1 commit into from
May 21, 2024

Conversation

deepthidevaki
Copy link
Contributor

Description

This PR doesn't fix the root cause where the writer buffer is full. But just map the error to RESOURCE_EXHAUSTED so that user's can know the request can be retried.

Related issues

closes #13018

@deepthidevaki deepthidevaki added backport stable/8.2 Backport a pull request to 8.2.x backport stable/8.3 Backport a pull request to 8.3.x backport stable/8.4 Backport a pull request to 8.4.x backport stable/8.5 Backport a pull request to stable/8.5 labels May 15, 2024
@github-actions github-actions bot added the component/zeebe Related to the Zeebe component/team label May 15, 2024
Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Really does make much more sense than internal error.

@deepthidevaki deepthidevaki added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit d7c2a70 May 21, 2024
49 checks passed
@deepthidevaki deepthidevaki deleted the dd-13018-writer-full-error branch May 21, 2024 09:34
@backport-action
Copy link
Collaborator

Backport failed for stable/8.2, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin stable/8.2
git worktree add -d .worktree/backport-18548-to-stable/8.2 origin/stable/8.2
cd .worktree/backport-18548-to-stable/8.2
git switch --create backport-18548-to-stable/8.2
git cherry-pick -x 472f0b369ada51e667cce3a74c14c3d00d8ec2f6

@backport-action
Copy link
Collaborator

Backport failed for stable/8.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin stable/8.3
git worktree add -d .worktree/backport-18548-to-stable/8.3 origin/stable/8.3
cd .worktree/backport-18548-to-stable/8.3
git switch --create backport-18548-to-stable/8.3
git cherry-pick -x 472f0b369ada51e667cce3a74c14c3d00d8ec2f6

@backport-action
Copy link
Collaborator

Backport failed for stable/8.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin stable/8.4
git worktree add -d .worktree/backport-18548-to-stable/8.4 origin/stable/8.4
cd .worktree/backport-18548-to-stable/8.4
git switch --create backport-18548-to-stable/8.4
git cherry-pick -x 472f0b369ada51e667cce3a74c14c3d00d8ec2f6

@backport-action
Copy link
Collaborator

Successfully created backport PR for stable/8.5:

github-merge-queue bot pushed a commit that referenced this pull request May 21, 2024
…uffer is full (#18668)

# Description
Backport of #18548 to `stable/8.5`.

relates to #13018
original author: @deepthidevaki
github-merge-queue bot pushed a commit that referenced this pull request May 22, 2024
…uffer is full (#18675)

## Description

Backport of #18548

## Related issues

closes #13018
github-merge-queue bot pushed a commit that referenced this pull request May 22, 2024
…usted when sequencer buffer is full (#18698)

# Description
Backport of #18675 to `stable/8.2`.

relates to #18548 #13018
original author: @deepthidevaki
github-merge-queue bot pushed a commit that referenced this pull request May 22, 2024
…usted when sequencer buffer is full (#18699)

# Description
Backport of #18675 to `stable/8.3`.

relates to #18548 #13018
original author: @deepthidevaki
@github-actions github-actions bot added version:8.5.2 Label that represents issues released on version 8.5.2 version:8.3.12 Label that represents issues released on version 8.3.12 version:8.2.28 Label that represents issues released on version 8.2.28 version:8.4.8 Label that represents issues released on version 8.4.8 labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stable/8.2 Backport a pull request to 8.2.x backport stable/8.3 Backport a pull request to 8.3.x backport stable/8.4 Backport a pull request to 8.4.x backport stable/8.5 Backport a pull request to stable/8.5 component/zeebe Related to the Zeebe component/team version:8.2.28 Label that represents issues released on version 8.2.28 version:8.3.12 Label that represents issues released on version 8.3.12 version:8.4.8 Label that represents issues released on version 8.4.8 version:8.5.2 Label that represents issues released on version 8.5.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endless errors on gateway because the writer is full
3 participants