-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: return resource_exhausted when sequencer buffer is full #18548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Really does make much more sense than internal error.
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/8.2
git worktree add -d .worktree/backport-18548-to-stable/8.2 origin/stable/8.2
cd .worktree/backport-18548-to-stable/8.2
git switch --create backport-18548-to-stable/8.2
git cherry-pick -x 472f0b369ada51e667cce3a74c14c3d00d8ec2f6 |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/8.3
git worktree add -d .worktree/backport-18548-to-stable/8.3 origin/stable/8.3
cd .worktree/backport-18548-to-stable/8.3
git switch --create backport-18548-to-stable/8.3
git cherry-pick -x 472f0b369ada51e667cce3a74c14c3d00d8ec2f6 |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin stable/8.4
git worktree add -d .worktree/backport-18548-to-stable/8.4 origin/stable/8.4
cd .worktree/backport-18548-to-stable/8.4
git switch --create backport-18548-to-stable/8.4
git cherry-pick -x 472f0b369ada51e667cce3a74c14c3d00d8ec2f6 |
Successfully created backport PR for |
…uffer is full (#18668) # Description Backport of #18548 to `stable/8.5`. relates to #13018 original author: @deepthidevaki
…usted when sequencer buffer is full (#18698) # Description Backport of #18675 to `stable/8.2`. relates to #18548 #13018 original author: @deepthidevaki
…usted when sequencer buffer is full (#18699) # Description Backport of #18675 to `stable/8.3`. relates to #18548 #13018 original author: @deepthidevaki
Description
This PR doesn't fix the root cause where the writer buffer is full. But just map the error to
RESOURCE_EXHAUSTED
so that user's can know the request can be retried.Related issues
closes #13018