Update authentication flow #18527
Merged
Update authentication flow #18527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ter-camunda-sdk/src/main/java/io/camunda/zeebe/spring/client/configuration/PropertyUtil.java
Show resolved
Hide resolved
.../main/java/io/camunda/zeebe/spring/client/properties/ZeebeClientConfigurationProperties.java
Show resolved
Hide resolved
.../main/java/io/camunda/zeebe/spring/client/properties/ZeebeClientConfigurationProperties.java
Show resolved
Hide resolved
nicpuppa
reviewed
May 15, 2024
There was a problem hiding this comment.
Hey @ana-vinogradova-camunda great work, I left a couple of questions. Please have a look
...src/main/java/io/camunda/zeebe/spring/client/configuration/ZeebeClientConfigurationImpl.java
Show resolved
Hide resolved
spring-boot-starter-camunda-sdk/src/main/resources/application-camunda-oidc.yaml
Show resolved
Hide resolved
...nda-sdk/src/test/java/io/camunda/zeebe/spring/client/config/CredentialsProviderSaasTest.java
Show resolved
Hide resolved
.../src/test/java/io/camunda/zeebe/spring/client/config/CredentialsProviderSelfManagedTest.java
Show resolved
Hide resolved
ana-vinogradova-camunda
force-pushed
the
17886-update-authentication-flow
branch
from
8feea7a
to
057ac00
Compare
|
I'm starting to backport your changes to |
Revert to initial authentication approach: leave only OAuthCredentialsProvider for all authentications, remove Authentication and its implementation.
Removing usages of Authentication classes and it's implementation as we are using OAuthCredentialsProvider now
Moving TokenRequest and TokenResponse to "token" package
Removing "simple" mode as it is not used
Adjusting tests to use OAuthCredentialsProvider instead of IdentityCredentialsProvider
Use CredentialsProvider instead of Authentication. Updated relevant tests.
Renaming the CamundaClientPropertiesOidcTest to CamundaClientPropertiesSelfManagedTest as it reflects the actual usage of this profile
Changing "isPlaintextConnectionEnabled" return type to support null value indicating that there is no configuration for it and avoiding using default value when the value is actually not set "getGrpcAddress" and "getRestAddress": Return null if not set so default value could be set after checking new config. This done because we check the old config first and only then - the new one.
This should be tested in configuration tests.
- add test for default properties - fixing getGrpcAddress default
- Adding correct issuer for SM - Removing client mode for SM as not needed - Removing unused dependency - Adding missing property to yaml files
using grpc address instead of deprecated gateway address
nicpuppa
force-pushed
the
17886-update-authentication-flow
branch
from
6417605
to
3fd915e
Compare
nicpuppa
approved these changes
May 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating authentication flow as per this issue description
Related issues
closes #17886