Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element template documentation link has odd coloring #4245

Open
nikku opened this issue Apr 15, 2024 · 3 comments
Open

Element template documentation link has odd coloring #4245

nikku opened this issue Apr 15, 2024 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers in progress Currently worked on properties panel spring cleaning Could be cleaned up one day

Comments

@nikku
Copy link
Member

nikku commented Apr 15, 2024

Describe the bug

Consider the colors of links in the modeler UI (different), where the properties panel link has an odd (not matching the existing color scheme) color:

image

Steps to reproduce

  1. Open test.bpmn from this project
  2. Click connector task
  3. See that documentation color link is off

Expected behavior

We use the same link color for various documentation links

Environment

  • OS: Linux
  • Camunda Modeler Version: v5.22.0
  • Execution Platform: any
  • Installed plug-ins: none

Additional context

The link is not styled and uses default styles. We should use color: var(--link-color) in element-templates or set default in properties panel

@nikku nikku added bug Something isn't working good first issue Good for newcomers spring cleaning Could be cleaned up one day properties panel labels Apr 15, 2024
@nikku nikku added backlog Queued in backlog ready Ready to be worked on labels Apr 15, 2024 — with bpmn-io-tasks
@nikku nikku removed the backlog Queued in backlog label Apr 15, 2024
@marstamm marstamm self-assigned this Apr 29, 2024
@marstamm marstamm assigned holygeek00 and unassigned marstamm May 7, 2024
holygeek00 added a commit to bpmn-io/bpmn-js-element-templates that referenced this issue May 7, 2024
@holygeek00 holygeek00 removed the ready Ready to be worked on label May 8, 2024
@nikku nikku reopened this May 8, 2024
@nikku
Copy link
Member Author

nikku commented May 8, 2024

@holygeek00 We usually move issues that are fixed upstream to the respective column on our board. An issue in Camunda Modeler is only closed once the fix (and upstream library release) is integrated in the Modeler app.

@nikku nikku added the fixed upstream Requires integration of upstream change label May 8, 2024
@nikku
Copy link
Member Author

nikku commented May 8, 2024

@holygeek00 Find my feedback on the fix here.

I wonder why the fix is not inside the Modeler, simply apply a proper --link-color to all a elements (so that it is appropriately styled automatically).

@nikku
Copy link
Member Author

nikku commented May 13, 2024

Following up here with what we discussed regarding "where to apply link styling".


As we discussed, two options:

  • Generalize the properties-panel styles, in @bpmn-io/properties-panel, all standard links should have a standard color
  • Move link styling to embedding application (entirely); there is little value in mandating a style inside a library; the application, i.e. Desktop or Web Modeler should define link colors, and the library should follow suite.

Interesting finding in this realm: In the Desktop Modeler we apply link colors (problem panel) in very interesting ways (instead of inheriting the current color of the element).

image

@nikku nikku added the in progress Currently worked on label May 13, 2024 — with bpmn-io-tasks
@nikku nikku removed the fixed upstream Requires integration of upstream change label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers in progress Currently worked on properties panel spring cleaning Could be cleaned up one day
Projects
None yet
Development

No branches or pull requests

3 participants