Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard shortcuts and menu entries for undo don't work in decision table #1843

Closed
barmac opened this issue Jun 23, 2020 · 2 comments · Fixed by #1911
Closed

Keyboard shortcuts and menu entries for undo don't work in decision table #1843

barmac opened this issue Jun 23, 2020 · 2 comments · Fixed by #1911
Assignees
@MaxTru
Labels
bug Something isn't working DMN
Milestone
M42

Comments

@barmac
Copy link
Contributor

barmac commented Jun 23, 2020

Describe the Bug

When I create input/output column or new rule, I cannot undo the action via menu or keyboard shortcuts.

The toolbar button still works, though.

Steps to Reproduce

  1. Create new input in decision table
  2. Press Cmd/Strg + Z or click menu entry for Undo
  3. now this happens

Expected Behavior

Shorcut should work.

Environment

  • OS: MacOS 10.15.4
  • Camunda Modeler Version: 3.7.1, 4.0.0, develop
@barmac barmac added bug Something isn't working DMN labels Jun 23, 2020
@MaxTru
Copy link
Contributor

MaxTru commented Jul 2, 2020

Bug can be reproduced with same behaviour on OS: Arch Linux (Modeler 4.0.0)

@philippfromme philippfromme added the backlog Queued in backlog label Jul 3, 2020
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed backlog Queued in backlog labels Aug 10, 2020
MaxTru added a commit that referenced this issue Aug 10, 2020
@MaxTru
fix(dmn-edit-menu): handle undo and redo entries manually
993c966 
closes #1843
MaxTru added a commit that referenced this issue Aug 10, 2020
@MaxTru
fix(dmn-edit-menu): handle undo and redo entries manually
863e564 
closes #1843
@MaxTru
Copy link
Contributor

MaxTru commented Aug 10, 2020

Seems to be related to this Chromium bug: electron/electron#3682

The fix we used here seems to solve the issue. Will investigate a bit further before creating the PR.

@MaxTru MaxTru mentioned this issue Aug 10, 2020
Merged
9 tasks
@MaxTru MaxTru added needs review Review pending and removed in progress Currently worked on labels Aug 10, 2020 — with bpmn-io-tasks
MaxTru added a commit that referenced this issue Aug 10, 2020
@MaxTru
fix(dmn-edit-menu): handle undo and redo without default
ddcc06a 
closes #1843
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Aug 10, 2020
@MaxTru MaxTru added needs review Review pending and removed in progress Currently worked on labels Aug 10, 2020 — with bpmn-io-tasks
MaxTru added a commit that referenced this issue Aug 17, 2020
@MaxTru
fix(dmn-edit-menu): handle undo and redo without default
a17b711 
closes #1843
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 18, 2020
MaxTru added a commit that referenced this issue Aug 18, 2020
@MaxTru
fix(dmn-edit-menu): handle undo and redo without default
66f9409 
closes #1843
@MaxTru MaxTru added this to the M42 milestone Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaxTru MaxTru

Labels
bug Something isn't working DMN
Projects
None yet
Milestone
M42
Development

Successfully merging a pull request may close this issue.

fix(dmn-edit-menu): handle undo and redo entries without default camunda/camunda-modeler
3 participants
@philippfromme @barmac @MaxTru