fix(frontend): performances issue on plans fetching #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(frontend): add loading spinner during plan fetching
hbollon
force-pushed
the
fix/plans_views_performences
branch
from
7c1fed1
to
9d80dea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(frontend): add loading spinner during plan fetching
This PR fix performances issues observed during plans fetching due to huge size of the response.
To achieve that I have:
/api/plans/summarywhich returns the metadata (data added by the wrapper) of the plans and I modified the view to use it on: the lineage view, the "plans explorer" view and the view of a plan (the last 10 plans displayed on the left)?planid=Xas a parameter to/api/plansin GET which allows it to return only a plan from its ID (since now I have to make an additional request to display a plan)