fix(frontend): performance issue with resource filter with multiples modules #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbollon
force-pushed
the
fix-resource-filter
branch
from
ffdd0ff
to
1d480e1
Compare
…modules feat(frontend): resource filter now match any substring in res path or name
hbollon
force-pushed
the
fix-resource-filter
branch
from
1d480e1
to
611134a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also optimized module span updating (the badge which indicate how many resources a module have and the number of them which match with the filter) by moving the code which handle it to the
updatedhook.