feat: add test environment with proper docker-compose using MinIO + add compatibility for it to AWS provider #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbollon
force-pushed
the
integration-test
branch
from
4d8860a
to
1563679
Compare
|
Very nice! I wonder though if it wouldn't be better to have two separate options |
You're right it will be more versatile like that, I'm doing this right away 👍 |
|
I added a new configuration structure for the common parameters to the different providers. We can therefore use them to do the same for other providers in the future. |
cryptobioz
approved these changes
Jun 15, 2021
This was referenced Jun 15, 2021
raphink
approved these changes
Jun 16, 2021
raphink
pushed a commit
that referenced
this pull request
Jun 16, 2021
…dd compatibility for it to AWS provider (#165) * feat: docker-compose for test environment using MinIO * feat: update AWS provider to be compatible with MinIO (and others S3 compatible ones) * feat: replace AWS_OTHER_COMPATIBLE_PROVIDER by two distinct generic parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraboard is now compatible with MinIO (and normally all others S3 compatble providers) using AWS sdk.
I added AWS_OTHER_COMPATIBLE_PROVIDER env variable to disable locks/versions support in order to make the AWS provider compatible with MinIO
The testing purpose environment seems done and ready, it only missing few .tfstates inluded with it.