Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable severity and SeverityLevels #156

Open
srindal opened this issue Apr 15, 2024 · 0 comments
Open

Configurable severity and SeverityLevels #156

srindal opened this issue Apr 15, 2024 · 0 comments

Comments

@srindal
Copy link

srindal commented Apr 15, 2024

Hi, coming from ver. 0.0.8 of your plugin I want to migrate to the react version. Besides having great features with regards to silencing alerts it also contains some changes to how severity-levels are handled with regards to sorting.

We use: info, warning, error, critical which was inspired by how the plugin worked in 0.0.8. But in 2.0 you have introduced the extra label severityValue which is a great idea, but you only map: critical, warning and info to the values: 1,2,3. Default is 4. This change makes the ordering of my severityLevels to be: critical, warning, info, error (since error is mapped to 4).

You have this PR open: #135 which suggests adding high between critical and warning. I have suggested to also have error as an option along with high.

I see too options. Either high and error both maps to severityValue 2 OR you move everything one place and have this ordering: critical, high, error, warning, info.

Either way is fine by me, but not mapping error to a severityvalue will break my sorting and make it difficult to move to ver. 2.0.

Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant