Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Solution Provided] Summarization by Alert State #103

Open
renzsickle opened this issue May 12, 2021 · 3 comments · May be fixed by #130
Open

[Solution Provided] Summarization by Alert State #103

renzsickle opened this issue May 12, 2021 · 3 comments · May be fixed by #130
Labels
enhancement status: pending

Comments

@renzsickle
Copy link

I've made a few changes for a customer and would like to offer them back to the core project. Could I get some feedback on the below?

In summary:

Added the ability to show an additional column with the state of each alert (active, suppressed or inhibited).
Added a summary display mode, which shows a count of alerts in each state (works better with the multistat panel).
Added the ability to toggle between full (original) and summary display modes.

In detail:

Added the ability to show an additional column with the state of each alert (active, suppressed or inhibited).
image
image
Added a summary display mode, which shows a count of alerts in each state (works better with the multistat panel). Added the ability to toggle between full (original) and summary display modes.
image
image
Column and label filters work in summary display mode.
image
Summary display mode easily translates into multistat panels.
image
Sample configuration for multistat panels:
image
image
If these changes are of interest, I have a patchfile ready to go.
@renzsickle renzsickle changed the title Summarization by Alert State [Solution Provided] Summarization by Alert State May 21, 2021
@hbollon
Copy link
Member

hbollon commented May 16, 2022

Hi @renzsickle,
Your additions seems very interesting !
Can you make a PR for me to have a look please?

@renzsickle
Copy link
Author

Sure. It's been some time since I posted this, but I have been able to branch from an older commit and apply the patch file. However, when I try to push my new branch up, I encounter the following error:

$ git push origin feature/alert_summary
ERROR: Permission to camptocamp/grafana-prometheus-alertmanager-datasource.git denied to renzsickle.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

As I haven't contributed to a project on Github before, this may well be an error in my configuration (I just setup a fresh SSH key) - or I might genuinely not have access (my new key was enough to clone the repository). I've also uploaded the patch below for viewing:

summary_view_patch.txt

It seems to apply cleanly to commit a22631e.

Please let me know how you'd like to proceed.

@hbollon
Copy link
Member

hbollon commented May 23, 2022

Hi @renzsickle
It's a normal behavior, you must create a PR from your own fork 😉

There is the how-to:

  1. Fork the project
  2. Create your feature branch (git checkout -b feature/AmazingFeature)
  3. Commit your changes (git commit -m 'Add some amazing stuff')
  4. Push to the branch (git push origin feature/AmazingFeature)
  5. Create a new Pull Request

Don't hesitate to ping me if you need further help 👍

@renzsickle renzsickle linked a pull request May 24, 2022 that will close this issue
Open
@hbollon hbollon linked a pull request May 24, 2022 that will close this issue
Applying patchfile as per Issue 103 - Summarization by Alert State #130
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement status: pending
Projects
None yet
Milestone
No milestone
2 participants
@renzsickle @hbollon