Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch playground to use e.g. Monaco editor #101

Open
polytypic opened this issue Jun 26, 2017 · 2 comments
Open

Switch playground to use e.g. Monaco editor #101

polytypic opened this issue Jun 26, 2017 · 2 comments

Comments

@polytypic
Copy link
Member

polytypic commented Jun 26, 2017

Currently the playground uses Klipse which uses CodeMirror. It works fine, but an editor like Monaco could fairly easily be configured to provide completion and online documentation.

@smeijer
Copy link

smeijer commented Oct 6, 2017

When working on a new playground, I think it would be awesome to add a small performance test loop to it. It doesn't need to be as advanced as jsperf, but a simple test so we can see how good a implementation of specific lenses perform.

The parsing of code in the playground can take some time, when a data object becomes larger (L.collectAs(myFn, [L.elems, 'sub', L.elems, 'path', L.choose....], largeDataObject). Being able to run the final L statement in a loop, would give some helpful feedback.

@polytypic
Copy link
Member Author

Hmm... Interesting idea! Note that all the current interactive pages (playground, exercises, and readme) use the development (rather than production) browser build of the library, which includes extra run-time checking code and runs significantly slower than the production build. So, it might be useful to have a separate benchmarking page with the production build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants