Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected errors are not being treated #2

Open
JoseRenan opened this issue Apr 17, 2018 · 0 comments
Open

Unexpected errors are not being treated #2

JoseRenan opened this issue Apr 17, 2018 · 0 comments
Labels
bug Something isn't working
Projects

Comments

@JoseRenan
Copy link
Member

JoseRenan commented Apr 17, 2018

When an unexpected error is thrown, it is not being treated and it's not returned on the HTTP response, making the request look like it hasn't finished yet.
It's needed to use a generic treatment for this kind of server errors returning the following response and logging the error stack, what will make the system more debuggable and won't let the client wait the time limit to get an answer from server.

default response:

{
       "status": 500,
       "message": "Unexpected server error ocurred"
}
@JoseRenan JoseRenan added the bug Something isn't working label Apr 17, 2018
@JoseRenan JoseRenan added this to To do in Task board Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Task board
  
To do
Development

No branches or pull requests

1 participant