Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Twipla app analytics added #14780

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Twipla app analytics added #14780

wants to merge 4 commits into from
+138 −0

Conversation

vikaspatil0021
Copy link
Contributor

@vikaspatil0021 vikaspatil0021 commented Apr 28, 2024 •
edited

This PR is to add Twipla analytics in the app store

fixes: #14758

loom video:
https://www.loom.com/share/2e97fea489044271b7f6f3fe03ccc52a

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • Add Twipla analytics application to an event type.
  • Open up the event page and it should automatically track it.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Apr 28, 2024
@graphite-app graphite-app bot requested a review from a team April 28, 2024 02:39
@vercel Vercel
Copy link

vercel bot commented Apr 28, 2024

@vikaspatil0021 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 28, 2024 •
edited

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@dosubot dosubot bot added app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar insights area: insights, analytics ✨ feature New feature or request labels Apr 28, 2024
@graphite-app graphite-app bot requested a review from a team April 28, 2024 02:40
@graphite-app Graphite App
Copy link

graphite-app bot commented Apr 28, 2024

Graphite Automations

"Add community label" took an action on this PR • (04/28/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (04/28/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (04/28/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@socket-security Socket Security
Copy link

socket-security bot commented Apr 28, 2024 •
edited

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/node@16.9.1 None 0 1.63 MB types
npm/@types/react@18.0.26 None 0 178 kB types
npm/querystring@0.2.0 None 0 33.3 kB gozala
npm/regenerator-runtime@0.14.1 None 0 27.9 kB benjamn
npm/yallist@4.0.0 None 0 14.8 kB isaacs

🚮 Removed packages: npm/@types/pretty-hrtime@1.0.3, npm/abbrev@1.1.1, npm/app-root-dir@1.0.2, npm/aproba@2.0.0, npm/arrify@1.0.1, npm/asap@2.0.6, npm/balanced-match@1.0.2, npm/chardet@0.7.0, npm/clone@1.0.4, npm/code-point-at@1.1.0, npm/color-support@1.1.3, npm/commondir@1.0.1, npm/component-emitter@1.3.1, npm/concat-map@0.0.1, npm/console-control-strings@1.1.0, npm/core-js@2.6.12, npm/decamelize@1.2.0, npm/delegates@1.0.0, npm/dotenv-expand@10.0.0, npm/dotenv@16.4.5, npm/esprima@4.0.1, npm/esutils@2.0.3, npm/extend@3.0.2, npm/fs.realpath@1.0.0, npm/functions-have-names@1.2.3, npm/has-bigints@1.0.2, npm/has-unicode@2.0.1, npm/hosted-git-info@2.8.9, npm/immutable@3.7.6, npm/invert-kv@1.0.0, npm/is-arrayish@0.2.1, npm/is-buffer@1.1.6, npm/is-extendable@0.1.1, npm/is-extglob@2.1.1, npm/is-negative-zero@2.0.3, npm/is-stream@1.1.0, npm/is-utf8@0.2.1, npm/is-windows@1.0.2, npm/isarray@2.0.5, npm/isexe@2.0.0, npm/isobject@3.0.1, npm/json-parse-better-errors@1.0.2, npm/json-stable-stringify-without-jsonify@1.0.1, npm/jsonify@0.0.1, npm/kind-of@6.0.3, npm/lodash.isarguments@3.1.0, npm/lodash.isequal@4.5.0, npm/map-cache@0.2.2, npm/memorystream@0.3.1, npm/minimist@1.2.8, npm/moment@2.30.1, npm/neo-async@2.6.2, npm/nice-try@1.0.5, npm/node-int64@0.4.0, npm/number-is-nan@1.0.1, npm/object-assign@4.1.1, npm/object-keys@1.1.1, npm/on-headers@1.0.2, npm/os-tmpdir@1.0.2, npm/p-finally@1.0.0, npm/p-try@2.2.0, npm/path-exists@4.0.0, npm/path-is-absolute@1.0.1, npm/path-parse@1.0.7, npm/pathe@1.1.2, npm/picomatch@2.3.1, npm/pretty-hrtime@1.0.3, npm/process-nextick-args@2.0.1, npm/prr@1.0.1, npm/punycode@2.3.1, npm/regenerate@1.4.2, npm/remove-trailing-separator@1.1.0, npm/repeat-string@1.6.1, npm/require-directory@2.1.1, npm/require-from-string@2.0.2, npm/resolve-from@5.0.0, npm/run-async@2.4.1, npm/set-blocking@2.0.0, npm/setimmediate@1.0.5, npm/shebang-regex@1.0.0, npm/shell-quote@1.8.1, npm/slash@3.0.0, npm/source-map@0.6.1, npm/sourcemap-codec@1.4.8, npm/spdx-exceptions@2.5.0, npm/spdx-license-ids@3.0.17, npm/sprintf-js@1.0.3, npm/strip-bom@3.0.0, npm/strip-eof@1.0.0, npm/supports-preserve-symlinks-flag@1.0.0, npm/text-table@0.2.0, npm/through@2.3.8, npm/tmpl@1.0.5, npm/ufo@1.5.3, npm/uglify-js@3.17.4, npm/universalify@0.1.2, npm/whatwg-fetch@3.6.20, npm/which-module@2.0.1, npm/wordwrap@1.0.0, npm/wrappy@1.0.2, npm/xtend@4.0.2, npm/yocto-queue@0.1.0

View full report↗︎

@vikaspatil0021 vikaspatil0021 changed the title Feat/ Twipla app analytics added feat/ Twipla app analytics added Apr 28, 2024
@vikaspatil0021 vikaspatil0021 changed the title feat/ Twipla app analytics added feat: Twipla app analytics added Apr 28, 2024
@PeerRich
Copy link
Member

looks great! can you uncommit your yarn.lock? main/CONTRIBUTING.md#guidelines-for-committing-yarn-lockfile

@socket-security Socket Security
Copy link

socket-security bot commented Apr 29, 2024 •
edited

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 29, 2024 •
edited

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Sixty-nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 278.39 KB 506.92 KB 144.84% (🟡 +0.23%)
/apps/[slug] 295.89 KB 524.43 KB 149.84% (🟡 +0.23%)
/apps/[slug]/[...pages] 586.58 KB 815.11 KB 232.89% (🟡 +0.24%)
/apps/categories 256.13 KB 484.66 KB 138.47% (🟡 +0.23%)
/apps/categories/[category] 260.47 KB 489 KB 139.72% (🟡 +0.23%)
/apps/installed/[category] 279.66 KB 508.19 KB 145.20% (🟡 +0.24%)
/availability 464.27 KB 692.8 KB 197.94% (🟡 +0.24%)
/availability/[schedule] 410.63 KB 639.16 KB 182.62% (🟡 +0.24%)
/bookings/[status] 323.92 KB 552.45 KB 157.84% (🟡 +0.25%)
/enterprise 256.18 KB 484.71 KB 138.49% (🟡 +0.23%)
/event-types 555.84 KB 784.37 KB 224.11% (🟡 +0.24%)
/event-types/[type] 435.25 KB 663.78 KB 189.65% (🟡 +0.24%)
/insights 475.09 KB 703.62 KB 201.03% (🟡 +0.23%)
/more 255.69 KB 484.22 KB 138.35% (🟡 +0.23%)
/settings/admin 261.77 KB 490.3 KB 140.09% (🟡 +0.23%)
/settings/admin/apps 274.89 KB 503.42 KB 143.83% (🟡 +0.24%)
/settings/admin/apps/[category] 274.87 KB 503.4 KB 143.83% (🟡 +0.24%)
/settings/admin/flags 265.88 KB 494.41 KB 141.26% (🟡 +0.23%)
/settings/admin/impersonation 262.13 KB 490.67 KB 140.19% (🟡 +0.23%)
/settings/admin/lockedSMS 282.89 KB 511.42 KB 146.12% (🟡 +0.23%)
/settings/admin/oAuth 273.93 KB 502.46 KB 143.56% (🟡 +0.23%)
/settings/admin/orgMigrations/_OrgMigrationLayout 250.14 KB 478.67 KB 136.76% (🟡 +0.23%)
/settings/admin/orgMigrations/moveTeamToOrg 299.81 KB 528.34 KB 150.95% (🟡 +0.24%)
/settings/admin/orgMigrations/moveUserToOrg 319.17 KB 547.71 KB 156.49% (🟡 +0.24%)
/settings/admin/orgMigrations/removeTeamFromOrg 299.56 KB 528.09 KB 150.88% (🟡 +0.24%)
/settings/admin/orgMigrations/removeUserFromOrg 299.57 KB 528.1 KB 150.89% (🟡 +0.23%)
/settings/admin/organizations 263.34 KB 491.87 KB 140.53% (🟡 +0.24%)
/settings/admin/organizations/[id]/edit 262.16 KB 490.69 KB 140.20% (🟡 +0.23%)
/settings/admin/users 264.02 KB 492.55 KB 140.73% (🟡 +0.23%)
/settings/admin/users/[id]/edit 392.67 KB 621.2 KB 177.49% (🟡 +0.23%)
/settings/admin/users/add 392.4 KB 620.93 KB 177.41% (🟡 +0.24%)
/settings/billing 261.88 KB 490.41 KB 140.12% (🟡 +0.23%)
/settings/developer/api-keys 265.93 KB 494.46 KB 141.28% (🟡 +0.23%)
/settings/developer/webhooks 266.01 KB 494.54 KB 141.30% (🟡 +0.23%)
/settings/developer/webhooks/[id] 267.02 KB 495.55 KB 141.59% (🟡 +0.23%)
/settings/developer/webhooks/new 267.02 KB 495.55 KB 141.59% (🟡 +0.23%)
/settings/my-account/appearance 314.7 KB 543.23 KB 155.21% (🟡 +0.24%)
/settings/my-account/calendars 272.45 KB 500.98 KB 143.14% (🟡 +0.24%)
/settings/my-account/conferencing 273.72 KB 502.25 KB 143.50% (🟡 +0.24%)
/settings/my-account/general 377.65 KB 606.18 KB 173.20% (🟡 +0.23%)
/settings/my-account/out-of-office 266.55 KB 495.08 KB 141.45% (🟡 +0.23%)
/settings/my-account/profile 405.18 KB 633.71 KB 181.06% (🟡 +0.23%)
/settings/organizations/appearance 285.83 KB 514.37 KB 146.96% (🟡 +0.23%)
/settings/organizations/billing 261.96 KB 490.49 KB 140.14% (🟡 +0.23%)
/settings/organizations/dsync 331.18 KB 559.71 KB 159.92% (🟡 +0.23%)
/settings/organizations/general 349.47 KB 578 KB 165.14% (🟡 +0.23%)
/settings/organizations/members 430.27 KB 658.8 KB 188.23% (🟡 +0.23%)
/settings/organizations/platform/oauth-clients 264.45 KB 492.98 KB 140.85% (🟡 +0.23%)
/settings/organizations/platform/oauth-clients/create 264.63 KB 493.16 KB 140.90% (🟡 +0.23%)
/settings/organizations/privacy 267.54 KB 496.08 KB 141.74% (🟡 +0.23%)
/settings/organizations/profile 397.95 KB 626.48 KB 178.99% (🟡 +0.23%)
/settings/organizations/sso 272.62 KB 501.15 KB 143.19% (🟡 +0.23%)
/settings/organizations/teams/other 262.53 KB 491.06 KB 140.30% (🟡 +0.23%)
/settings/organizations/teams/other/[id]/appearance 274.67 KB 503.2 KB 143.77% (🟡 +0.23%)
/settings/organizations/teams/other/[id]/members 269.62 KB 498.15 KB 142.33% (🟡 +0.23%)
/settings/organizations/teams/other/[id]/profile 468.35 KB 696.88 KB 199.11% (🟡 +0.23%)
/settings/security/impersonation 266.78 KB 495.31 KB 141.52% (🟡 +0.23%)
/settings/security/password 304.31 KB 532.85 KB 152.24% (🟡 +0.24%)
/settings/security/sso 271.95 KB 500.48 KB 142.99% (🟡 +0.23%)
/settings/security/two-factor-auth 270.21 KB 498.74 KB 142.50% (🟡 +0.23%)
/settings/teams 261.44 KB 489.97 KB 139.99% (🟡 +0.23%)
/settings/teams/[id]/appearance 274.66 KB 503.19 KB 143.77% (🟡 +0.23%)
/settings/teams/[id]/billing 261.96 KB 490.49 KB 140.14% (🟡 +0.23%)
/settings/teams/[id]/members 379.54 KB 608.07 KB 173.73% (🟡 +0.23%)
/settings/teams/[id]/profile 469.19 KB 697.72 KB 199.35% (🟡 +0.23%)
/teams 255.92 KB 484.45 KB 138.41% (🟡 +0.23%)
/upgrade 256.04 KB 484.57 KB 138.45% (🟡 +0.23%)
/workflows 287.34 KB 515.87 KB 147.39% (🟡 +0.23%)
/workflows/[workflow] 409.72 KB 638.25 KB 182.36% (🟡 +0.24%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@vikaspatil0021
Copy link
Contributor Author

@PeerRich Any updates on this?

@keithwillcode keithwillcode added this to the v4.1 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar community Created by Linear-GitHub Sync ✨ feature New feature or request insights area: insights, analytics
Projects
None yet
Milestone
v4.1
Development

Successfully merging this pull request may close these issues.

[CAL-3557] add twipla
3 participants
@vikaspatil0021 @PeerRich @keithwillcode