Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAL-3511] ability to add guests via app.cal.com/bookings #14691

Open
PeerRich opened this issue Apr 21, 2024 · 4 comments · May be fixed by #14740
Open

[CAL-3511] ability to add guests via app.cal.com/bookings #14691

PeerRich opened this issue Apr 21, 2024 · 4 comments · May be fixed by #14740
Labels
booking-page area: booking page, public booking page, booker ✨ feature New feature or request Low priority Created by Linear-GitHub Sync

Comments

@PeerRich
Copy link
Member

PeerRich commented Apr 21, 2024 •
edited

https://x.com/pbteja1998/status/1782161880854769929

CAL-3511
@PeerRich PeerRich changed the title ability to add guests after the event via app.cal.com/bookings [CAL-3511] ability to add guests after the event via app.cal.com/bookings Apr 21, 2024
@PeerRich PeerRich changed the title [CAL-3511] ability to add guests after the event via app.cal.com/bookings [CAL-3511] ability to add guests via app.cal.com/bookings Apr 21, 2024
@PeerRich
Copy link
Member Author

we should rename: "Edit location" to "Edit"
CleanShot 2024-04-21 at 23 49 00@2x

and then in the dialog add more settings, such as "Add guests" and later more things

CleanShot 2024-04-21 at 23 49 37@2x

@dosubot dosubot bot added booking-page area: booking page, public booking page, booker ✨ feature New feature or request labels Apr 21, 2024
@jayeshp19
Copy link

jayeshp19 commented Apr 22, 2024 •
edited

@PeerRich, I'd be glad to take this task on. I've already begun working on it. However, I wanted to know your opinion on the approach. We currently have an "Edit" option at the top of the dropdown. Would changing "Edit Location" to "Edit" potentially cause any confusion?
image

I can think of two potential solutions:

  1. We could introduce a new button for "Add guests" below the "Edit Location" in the dropdown.
  2. Alternatively, we could transform "Edit" into a button rather than a dropdown. Clicking on it would open a dialog containing all the settings such as "Reschedule Booking", "Reschedule Request", "Change Location", "Add Guests", etc.

Please let me know what do you think?

@jayeshp19
Copy link

@PeerRich @zomars @Udit-takkar can you please suggest your inputs?

@anikdhabal anikdhabal linked a pull request Apr 25, 2024 that will close this issue
Open
@anikdhabal
Copy link
Contributor

@PeerRich @zomars @Udit-takkar can you please suggest your inputs?

Hey @jayeshp19 I worked on it and fixed by today. By the way, I also positioned the button in the same place. Thank you.

@PeerRich PeerRich added the Low priority Created by Linear-GitHub Sync label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
booking-page area: booking page, public booking page, booker ✨ feature New feature or request Low priority Created by Linear-GitHub Sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: ability to add guests via app.cal.com/bookings anikdhabal/cal.com
3 participants
@PeerRich @jayeshp19 @anikdhabal