Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event booking - one input label lacks Polish translation #14734

Open
agilido opened this issue Apr 24, 2024 · 5 comments · May be fixed by #14863
Open

Event booking - one input label lacks Polish translation #14734

agilido opened this issue Apr 24, 2024 · 5 comments · May be fixed by #14863
Labels
i18n area: i18n, translations

Comments

@agilido
Copy link

agilido commented Apr 24, 2024

Issue Summary

When booking a meeting, after choosing the hour, first input label is "Your name" instead of "Imię i nazwisko".

Steps to Reproduce

  1. Go to cal.com/(user)/(event)
  2. Choose date and hour.

Actual Results

  • After choosing the hour, first input label is "Your name" instead of "Imię i nazwisko".

Expected Results

  • Input label "Your name" should say for Polish "Imię i nazwisko".

Technical details

  • Happens on every browser.

Evidence

image

Copy link

dosubot bot commented Apr 24, 2024

To address the issue with the "Your name" input label not being translated into Polish ("Imię i nazwisko") on the Cal.com event booking form, you can use the upsertBookingField function in the packages/features/eventtypes/lib/bookingFieldsManager.ts file. This function allows for the addition or update of booking fields for specific event types. Here's how you might use it:

await upsertBookingField(
  { name: "name", label: "Your name" }, // Current field and label
  { id: "pl", label: "Imię i nazwisko", fieldRequired: true }, // New label for Polish
  eventTypeId // ID of the event type being updated
);

Ensure you replace "name" with the actual field identifier and eventTypeId with the ID of the event type you're updating. This example assumes the field's identifier is "name" and updates the label for the Polish language setting.

For more details, refer to the bookingFieldsManager.ts file in the Cal.com repository. This should resolve the translation issue for the input label in the event booking form.

Details

Sources


About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

To continue the conversation, mention @dosu.

@dosubot dosubot bot added the i18n area: i18n, translations label Apr 24, 2024
@agilido agilido changed the title Event booking - one input lacks Polish translation Event booking - one input label lacks Polish translation Apr 24, 2024
@heykvr
Copy link

heykvr commented Apr 26, 2024

@dosu can i pick up this ?

@smitgol
Copy link

smitgol commented May 1, 2024

I found out found its not about the translation.

The issue is from configMap in fieldTypes.ts file. Where in name default Value is "Your Name" instead of your_name.And also when rendering name field in Component.tsx in formbuilder there we don't translating the any field Type variants.

@smitgol
Copy link

smitgol commented May 1, 2024

we can use this function getAndUpdateNormalizedValues(variantField, t) in Component.tsx file.But again we are only translating the defaultLabel not Label from configMap in fieldTypes.ts

@smitgol smitgol linked a pull request May 2, 2024 that will close this issue
1 task
@smitgol
Copy link

smitgol commented May 2, 2024

#14863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n area: i18n, translations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants