Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAL-3526] /signup flickers i18n #14733

Open
PeerRich opened this issue Apr 24, 2024 · 1 comment
Open

[CAL-3526] /signup flickers i18n #14733

PeerRich opened this issue Apr 24, 2024 · 1 comment
Labels
🐛 bug Something isn't working i18n area: i18n, translations Low priority Created by Linear-GitHub Sync

Comments

@PeerRich
Copy link
Member

PeerRich commented Apr 24, 2024 •
edited

when visiting cal.com/sales the i18n strings flicker

trim.04975C3F-950B-4289-B7ED-300205897556.MOV

CAL-3526
@PeerRich PeerRich changed the title /signup flickers i18n [CAL-3526] /signup flickers i18n Apr 24, 2024
@dosubot dosubot bot added i18n area: i18n, translations 🐛 bug Something isn't working labels Apr 24, 2024
@HyperDanisH
Copy link

This flicker is begin caused due to Locale not being ready at first render of signup component. We can verify it by console logging isLocaleReady variable coming from useLocale() react hook inside signup page. One way we can fix this is by using skeleton structure while the locale is getting ready.

If this is the fix that you recommend then I would love to take this issue on.

@PeerRich PeerRich added the Low priority Created by Linear-GitHub Sync label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working i18n area: i18n, translations Low priority Created by Linear-GitHub Sync
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PeerRich @HyperDanisH