Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify logic by removing unnecessary // ts-ignore #14621

Open
kaleem68 opened this issue Apr 16, 2024 · 4 comments · May be fixed by #14622
Open

Simplify logic by removing unnecessary // ts-ignore #14621

kaleem68 opened this issue Apr 16, 2024 · 4 comments · May be fixed by #14622
Labels
💻 refactor

Comments

@kaleem68
Copy link
Contributor

kaleem68 commented Apr 16, 2024 •
edited

In packages/platform/sdk/src/lib/entpoints/getEndpointData

The endpointData.constructUri expects string[] and the code is forcefully converting Record<string,string> to string[] and suppressing with // ts-ignore

Suggestions

Either combine both if and else if and convert params to string[] to get rid of ts-ignore OR
make endpointData.constructUri accept string[] | Record<string,string>

Screenshot 2024-04-17 at 3 53 32 AM
@kaleem68 kaleem68 linked a pull request Apr 16, 2024 that will close this issue
Open
@Aniruddha775
Copy link

hey is this issue still open?

@kaleem68
Copy link
Contributor Author

@Aniruddha775 Yes issue is opened
I also have created PR Pr for 14621

@Aniruddha775
Copy link

@kaleem68 so it is not yet merged right, so can i work on this?

@kaleem68
Copy link
Contributor Author

@Aniruddha775 Yes you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove ts-ignore by converting to string[] kaleem68/cal.com
2 participants
@kaleem68 @Aniruddha775