New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

share amounts must be seen in conjunction with onboarding step #187

Open

dfangshuo opened this issue May 4, 2020 · 0 comments

Labels

Contributor

dfangshuo commented May 4, 2020

A non-0 share amounts in the owner object does not AND SHOULD NOT count for anything unless onboarding step == -1.

This is because in onboarding, we currently update # shares in the owner object before the user pays in:

the screen where the user selects the # of shares
invite via a pledge invite

This means that if onboarding step is ever removed in the future, this feature needs to change, lest owners have 'shares' they never paid for

dfangshuo added the Known Issue label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment