Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - audit mart_gtfs_schedule_latest #3340

Merged
merged 5 commits into from
May 16, 2024

Conversation

tiffanychu90
Copy link
Member

@tiffanychu90 tiffanychu90 commented May 15, 2024

Description

Describe your changes and why you're making them. Please include the context, motivation, and relevant dependencies.

Resolves #3104

  • Use yaml anchors in mart/gtfs_schedule_latest/_gtfs_schedule_latest.yml
  • Fill in columns missing documentation, except for exposure dim_shapes_arrays_latest. Columns are not defined where the exposures are.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

  • poetry run dbt docs generate
docs_audit

Post-merge follow-ups

Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.

  • No action required
  • Actions required (specified below)

@tiffanychu90 tiffanychu90 removed the request for review from SorenSpicknall May 15, 2024 17:40
@tiffanychu90 tiffanychu90 removed the request for review from hunterowens May 15, 2024 18:37
@tiffanychu90 tiffanychu90 marked this pull request as draft May 15, 2024 20:20
@tiffanychu90 tiffanychu90 marked this pull request as ready for review May 15, 2024 23:32
@tiffanychu90 tiffanychu90 force-pushed the docs-audit-mart_gtfs_schedule_latest branch from a816af7 to 0a276f5 Compare May 16, 2024 21:24
Copy link
Contributor

@vevetron vevetron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiffanychu90 tiffanychu90 merged commit e30c9dd into main May 16, 2024
4 checks passed
@tiffanychu90 tiffanychu90 deleted the docs-audit-mart_gtfs_schedule_latest branch May 16, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document all columns in mart_gtfs_schedule_latest & review YAML
2 participants