Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor enrollment check to lookup groups for funding source #2041

Closed
1 task
thekaveman opened this issue Apr 18, 2024 · 1 comment
Closed
1 task

Refactor enrollment check to lookup groups for funding source #2041

thekaveman opened this issue Apr 18, 2024 · 1 comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. duplicate This issue or pull request already exists

Comments

@thekaveman
Copy link
Member

This is blocked until cal-itp/littlepay#60 is released.

Right now we lookup all funding sources for a given group, and check if the current user's funding source is in that list.

This change will invert the lookup -- we'll get the groups for the current user's funding source, which is likely a much smaller list to check.

Acceptance Criteria

  • The re-enrollment check happens by looking up groups for the current user's funding source, and checking if the group they are attempting to enroll in is in that list
@thekaveman thekaveman added the back-end Django views, sessions, middleware, models, migrations etc. label Apr 18, 2024
@thekaveman
Copy link
Member Author

Oops, I opened #2068 forgetting that I had already opened this one. I like the description in that one better, closing this as a dupe.

@thekaveman thekaveman closed this as not planned Won't fix, can't repro, duplicate, stale May 1, 2024
@thekaveman thekaveman added the duplicate This issue or pull request already exists label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Django views, sessions, middleware, models, migrations etc. duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

1 participant