Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift all screens so the headline is 148px spacing from the top (to follow 8-pt grid) #2016

Open
2 tasks
Tracked by #2025
angela-tran opened this issue Apr 10, 2024 · 2 comments
Open
2 tasks
Tracked by #2025
Labels
design UX/UI research and tasks: Figma

Comments

@angela-tran
Copy link
Member

While doing design review for #1907 / #2006, we (@indexing @srhhnry @thekaveman @angela-tran @lalver1) noticed that the designs in Figma call for spacing of 150px between the top of the page and the heading. We've been working towards using a 8-pt grid system for all designs (i.e. values for spacing are multiples of 8), and this would be an easy one to do.

Acceptance Criteria

  • Figma designs have been updated
  • Once Figma is updated, devs implement code change
@angela-tran angela-tran added the design UX/UI research and tasks: Figma label Apr 10, 2024
@angela-tran
Copy link
Member Author

angela-tran commented Apr 10, 2024

@indexing @srhhnry -- is this the right definition of 8-pt grid?

We've been working towards using a 8-pt grid system for all designs (i.e. values for spacing are multiples of 8), ...

And if so, is 148px the correct value? 148 / 8 = 18.5

@indexing
Copy link
Member

So, yeah, for a value that is currently 150, we'd choose either 152 or 144. Rounding to the nearest multiple, we'd go with 152. If the spacing looks too large, go with 144. Thoughts on one or the other @srhhnry ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design UX/UI research and tasks: Figma
Projects
Status: Stretch
Development

No branches or pull requests

2 participants