Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strong-name sign Abstractions and Transport #133

Closed
bjorkstromm opened this issue Apr 30, 2021 · 4 comments · Fixed by #134
Closed

Strong-name sign Abstractions and Transport #133

bjorkstromm opened this issue Apr 30, 2021 · 4 comments · Fixed by #134
Assignees
Milestone

Comments

@bjorkstromm
Copy link
Member

Needed for OmniSharp/omnisharp-roslyn#2143

@bjorkstromm bjorkstromm self-assigned this Apr 30, 2021
@bjorkstromm bjorkstromm added this to the 0.6.3 milestone Apr 30, 2021
@333fred
Copy link

333fred commented Apr 30, 2021

Hopefully we do have a workaround by using https://github.com/dsplaisted/strongnamer, but it would be good to have all dependencies actually strong-name signed. Should help anyone else who runs into similar problems.

@gep13
Copy link
Member

gep13 commented Apr 30, 2021

@333fred I have used this tool https://github.com/brutaldev/StrongNameSigner on the Chocolatey code base when we have needed to sign some dependencies that aren't strong named, and this has worked really well for us.

@333fred
Copy link

333fred commented Apr 30, 2021

@333fred I have used this tool https://github.com/brutaldev/StrongNameSigner on the Chocolatey code base when we have needed to sign some dependencies that aren't strong named, and this has worked really well for us.

I tried that one first, actually. It didn't appear to work with recent versions of msbuild.

@gep13
Copy link
Member

gep13 commented Apr 30, 2021

Hmm, this might be some fun in my immediate future then ☹️ Chocolatey is currently targeting older versions of MSBuild for backwards compatibility, which is likely why we haven't seen problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants